-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set null prototype on namespace objects. #3136
Set null prototype on namespace objects. #3136
Conversation
Can you check the remaining test failures? It seems to be just four left |
Ah, now it is running :) |
And sorry, there are some conflicts with master now 🙄 |
Codecov Report
@@ Coverage Diff @@
## master #3136 +/- ##
==========================================
+ Coverage 89.31% 89.31% +<.01%
==========================================
Files 165 165
Lines 5726 5727 +1
Branches 1737 1737
==========================================
+ Hits 5114 5115 +1
Misses 379 379
Partials 233 233
Continue to review full report at Codecov.
|
@lukastaegert Think it's good now, tests are passing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: #3096
Description
Set null prototype on namespace objects by using __proto__. Previously it was not set so used default
Object.prototype
. ECMAScript spec defines ES module namespaces as exotic objects and says that their [[Prototype]] should be null.